Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252661: Change SafepointMechanism terminology to talk less about "blocking" #54

Closed
wants to merge 1 commit into from

Conversation

fisk
Copy link
Contributor

@fisk fisk commented Sep 7, 2020

Migrating this review from the mailing list into a pull request. So far, the favourite terminology is to talk about "process", but without "operation".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252661: Change SafepointMechanism terminology to talk less about "blocking"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/54/head:pull/54
$ git checkout pull/54

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@fisk The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@shipilev
Copy link
Member

shipilev commented Sep 7, 2020

/review

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@shipilev Unknown command review - for a list of valid commands use /help.

@shipilev
Copy link
Member

shipilev commented Sep 7, 2020

/reviewer shade

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@shipilev Only the author (@fisk) is allowed to issue the reviewer command.

@shipilev
Copy link
Member

shipilev commented Sep 7, 2020

Okay, I am somewhat confused how Skara is supposed to register my review here. Reviewed!

robehn
robehn approved these changes Sep 7, 2020
Copy link
Contributor

@robehn robehn left a comment

I think we can do better than "process".
I can't think anything now, so ship it.

Thanks

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@fisk This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252661: Change SafepointMechanism terminology to talk less about "blocking"

Reviewed-by: rehn, shade, dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate e0c8d4420c8e1a84581927cf77314498b8e5aa52.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2020
@fisk
Copy link
Contributor Author

fisk commented Sep 7, 2020

Thanks for the reviews, @shipilev and @robehn. I'll add David Holmes as reviewer too, as the final name suggestion was his.

@fisk
Copy link
Contributor Author

fisk commented Sep 7, 2020

/reviewer dholmes

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@fisk Syntax: /reviewer (add|remove) [@user | openjdk-user]+. For example:

  • /reviewer add @openjdk-bot
  • /reviewer add duke
  • /reviewer add @user1 @user2

@fisk
Copy link
Contributor Author

fisk commented Sep 7, 2020

/reviewer add dholmes

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@fisk
Reviewer dholmes successfully added.

@fisk
Copy link
Contributor Author

fisk commented Sep 7, 2020

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@fisk Pushed as commit e29c3f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants