Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267636: Bump minimum boot jdk to JDK 17 #5639

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Sep 22, 2021

With the JDK 17 GA out it's time to bump the minimum boot JDK version for mainline/JDK 18.

Testing: tier1-5, GHA builds


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5639/head:pull/5639
$ git checkout pull/5639

Update a local copy of the PR:
$ git checkout pull/5639
$ git pull https://git.openjdk.java.net/jdk pull/5639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5639

View PR using the GUI difftool:
$ git pr show -t 5639

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5639.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Sep 22, 2021
@vidmik vidmik changed the title WIP: 8267636: Bump minimum boot jdk to JDK 17 8267636: Bump minimum boot jdk to JDK 17 Sep 23, 2021
@openjdk openjdk bot added the rfr label Sep 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267636: Bump minimum boot jdk to JDK 17

Reviewed-by: darcy, erikj, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 0aa63fe: 8274216: ProblemList 2 serviceability/dcmd/gc tests with ZGC on linux-all and windows-all
  • 5ffbe75: 8274195: Doc cleanup in java.nio.file
  • 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/81d416477f9856861a5af13058bfc3028bcb9b60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2021
@vidmik
Copy link
Contributor Author

@vidmik vidmik commented Sep 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

Going to push as commit 75404ea.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 14100d5: 8274170: Add hooks for custom makefiles to augment jtreg test execution
  • daaa47e: 8274311: Make build.tools.jigsaw.GenGraphs more configurable
  • 2cffe4c: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • 172900d: 8274255: Update javac messages to use "enum class" rather than "enum type"
  • b0983df: 8274074: SIGFPE with C2 compiled code with -XX:+StressGCM
  • 7436a77: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor
  • 7426fd4: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160
  • e3aff8f: 8274289: jdk/jfr/api/consumer/TestRecordedFrameType.java failed with "RuntimeException: assertNotEquals: expected Interpreted to not equal Interpreted"
  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/81d416477f9856861a5af13058bfc3028bcb9b60...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@vidmik Pushed as commit 75404ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants