Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8274233: Minor cleanup for ToolBox #5667


Copy link

@jonathan-gibbons jonathan-gibbons commented Sep 23, 2021

Please review some superficial cleanup to the ToolBox class. There are no API changes and no changes to any tests.

  1. Change Paths.get to Path.of
  2. Minor code cleanup suggested by IDE, such as removing unnecessary type parameters, etc
  3. Reformat doc comments to commonly prevailing standards


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed




Using git

Checkout this PR locally:
$ git fetch pull/5667/head:pull/5667
$ git checkout pull/5667

Update a local copy of the PR:
$ git checkout pull/5667
$ git pull pull/5667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5667

View PR using the GUI difftool:
$ git pr show -t 5667

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Sep 23, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2021
Copy link

openjdk bot commented Sep 23, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Sep 23, 2021
Copy link

mlbridge bot commented Sep 23, 2021


Copy link

openjdk bot commented Sep 24, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8274233: Minor cleanup for ToolBox

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 56b8b35: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2021
Copy link
Contributor Author


Copy link

openjdk bot commented Sep 24, 2021

Going to push as commit e741a18.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • 5a12af7: 8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • db23ecd: 8274191: Improve g1 evacuation failure injector performance
  • d91e227: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • 971aa35: 8274083: Update testing docs to mention tiered testing
  • 1d44014: 8273034: Make javadoc navigation collapsible on small displays
  • bb74ae8: 8274171: java/nio/file/Files/probeContentType/ failed on "Content type" mismatches
  • ... and 1 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2021
Copy link

openjdk bot commented Sep 24, 2021

@jonathan-gibbons Pushed as commit e741a18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8274233.toolbox-cleanup branch September 24, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
compiler integrated Pull request has been integrated
2 participants