8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos

[azvegint]

Looks like this test does not fail anymore.

It does not fail once even without changes, but I've added extra waitForIdle() just for safety.

Checked on ~350 test runs.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos

Reviewers

• Pankaj Bansal (@pankaj-bansal - Reviewer) ⚠️ Review applies to 5218b7b
• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to e1c0625
• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• Phil Race (@prrace - Reviewer) ⚠️ Review applies to e1c0625

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6015/head:pull/6015
$ git checkout pull/6015

Update a local copy of the PR:
$ git checkout pull/6015
$ git pull https://git.openjdk.java.net/jdk pull/6015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6015

View PR using the GUI difftool:
$ git pr show -t 6015

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6015.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ae25e228)
• 01: Full - Incremental (e1c0625e)
• 00: Full (5218b7b7)

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos

Reviewed-by: pbansal, serb, psadhukhan, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
• 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
• 135cf3c: 8275439: Remove PrintVtableStats
• 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
• 5454a76: 8275273: Add missing HtmlStyle documentation
• bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
• 77b2789: 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key
• c24fb85: 8275512: Upgrade required version of jtreg to 6.1
• 926966b: 8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi
• e63c148: 8264849: Add KW and KWP support to PKCS11 provider
• ... and 36 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

I guess you can remove @modules sun.awt which is not needed anymore..
Also, since you are touching the test, you probably can replace wildcard imports and remove author tag.
Additionally, i believe we should throw exception instead of catching and only print stacktrace at end of file.

[azvegint]

I guess you can remove @modules sun.awt which is not needed anymore.. Also, since you are touching the test, you probably can replace wildcard imports and remove author tag. Additionally, i believe we should throw exception instead of catching and only print stacktrace at end of file.

updated, testing still green.

[prsadhuk]

One more thing..since you are setting apple.laf.useScreenMenuBar property, wouldn't it be prudent to run the test in main/othervm mode explicitly?

[prrace]

One for the monitor list.
Could you add this bug ID to the @bug list - so it can be found more easily in case of recurrence ?

[mrserb]

All tests for java client should be configured to be run, it is done via othervm.dirs option in the TEST.ROOT

[prsadhuk]

It is run in othervm mode for java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java
java/awt/MenuBar/DefaultMenuBarDispose.java, java/awt/MenuBar/TestNoScreenMenuBar.java
setting the same property so I asked.
I know all jtreg tests are run in othervm mode but, in last few weeks, couple of tests have set othervm mode explicitly to be more safe PR of which was approved.

[azvegint]

/integrate

[openjdk]

Going to push as commit 46b5bfb.
Since your change was applied there have been 50 commits pushed to the master branch:

• bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
• 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
• 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
• 043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
• a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
• 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
• 135cf3c: 8275439: Remove PrintVtableStats
• 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
• 5454a76: 8275273: Add missing HtmlStyle documentation
• bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
• ... and 40 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit 46b5bfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.