JDK-8275923: Override the LPR path using a system property

[rhbvkleef]

On some select systems, the LPR binary may be placed elsewhere (for example at /app/bin/lpr). For that reason, we need to be able to override this value. This proposal also allows overriding the LP's path, as it could experience similar difficulties.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8275923

Issue

• JDK-8275923: Allow overriding the path to the lpr binary ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6052/head:pull/6052
$ git checkout pull/6052

Update a local copy of the PR:
$ git checkout pull/6052
$ git pull https://git.openjdk.java.net/jdk pull/6052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6052

View PR using the GUI difftool:
$ git pr show -t 6052

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6052.diff

[bridgekeeper]

Hi @rhbvkleef, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rhbvkleef" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@rhbvkleef The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[rhbvkleef]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[magicus]

Hi @rhbvkleef,

This PR is not going to be noticed by anyone who can review it. Please send an email to the relevant mailing lists (in this case client-dev@openjdk.java.net) to raise a discussion and, hopefully, have someone sponsor this PR.

[rhbvkleef]

@magicus

in this case client-dev@openjdk.java.net

That mailing list doesn't exist.

[magicus]

Sorry it's client-libs-dev@openjdk.java.net.

[mlbridge]

Webrevs

• 00: Full (7f75e371)

[prrace]

/csr

[openjdk]

@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@rhbvkleef please create a CSR request for issue JDK-8275923. This pull request cannot be integrated until the CSR request is approved.

[prrace]

This needs a CSR since it introduces a new interface.
I also think we should consider if the hard coded path were always tried first and only if it doesn't exist would
we try the property ..
then we'd name the property appropriately, eg
-Dsun.print.lprFallbackCommand=/app/foo/lpr
"Command" not "Path".

I will also check with the team that assesses secure coding etc to ask what they think.

[bridgekeeper]

@rhbvkleef This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[prrace]

Updates more or less along the lines above might make this acceptable

1. The hardcoded location is tried first REGARDLESS of whether the property is set
2. The property is only read ONCE - in something like a static initializer for the class or some mechanism that has the same effect.
3. The property name is as described above.

[bridgekeeper]

@rhbvkleef This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@rhbvkleef This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[nanonyme]

Hi @nanonyme, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user nanonyme for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.