Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254696: safepointMechanism_aix needs adaptation for JDK-8253180 #635

Closed

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 13, 2020

JDK-8253180 changed SafepointMechanism::default_initialize(). SafepointMechanism::pd_initialize() in safepointMechanism_aix.cpp needs the same changes in order to fix build and initialization.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254696: safepointMechanism_aix needs adaptation for JDK-8253180

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/635/head:pull/635
$ git checkout pull/635

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 13, 2020

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2020

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks to be consistent with JDK-8253180 changes.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254696: safepointMechanism_aix needs adaptation for JDK-8253180

Reviewed-by: dholmes, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • b509e31: 8254602: compiler/debug/TestStressCM.java failed with "RuntimeException: got the same optimization stats for different seeds: expected 45"
  • 9fe9b24: 8254575: C2: Clean up unused TRACK_PHI_INPUTS assertion code
  • 31d9b7f: 8254252: Generic arraycopy stub overwrites callee-save rdi register on 64-bit Windows
  • a098037: 8254365: ciMethod.hpp should not include methodHandles.hpp
  • d50e0de: 8254722: bsd_zero builds broken after JDK-8253717
  • ba5dc67: 8254158: Consolidate per-platform stack overflow handling code
  • 715e24a: 8254311: Incorrect statements in createWindowsDevkit2017.sh
  • ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
  • 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
  • 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/9c9349098ac2f1f797cdf8490e2eefccb95ecde2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 14, 2020
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 14, 2020

Thanks for the reviews!

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 14, 2020

/integrate

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@TheRealMDoerr Since your change was applied there have been 13 commits pushed to the master branch:

  • b509e31: 8254602: compiler/debug/TestStressCM.java failed with "RuntimeException: got the same optimization stats for different seeds: expected 45"
  • 9fe9b24: 8254575: C2: Clean up unused TRACK_PHI_INPUTS assertion code
  • 31d9b7f: 8254252: Generic arraycopy stub overwrites callee-save rdi register on 64-bit Windows
  • a098037: 8254365: ciMethod.hpp should not include methodHandles.hpp
  • d50e0de: 8254722: bsd_zero builds broken after JDK-8253717
  • ba5dc67: 8254158: Consolidate per-platform stack overflow handling code
  • 715e24a: 8254311: Incorrect statements in createWindowsDevkit2017.sh
  • ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
  • 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
  • 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/9c9349098ac2f1f797cdf8490e2eefccb95ecde2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9eeeb8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Oct 14, 2020
@TheRealMDoerr TheRealMDoerr deleted the 8254696_aix_build branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants