-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278282: G1: Log basic statistics of evacuation failure #6763
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
/issue add JDK-8278283 |
@Hamlin-Li |
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Seems the jdk mail service was done, ping ~ |
/label hotspot-gc |
@Hamlin-Li |
ping again ~ test mail service |
Haven't looked in detail at the patch yet, but I have a comment on the output.
I thought we agreed on having more things on debug level and using "Evacuation Failure Regions" for now (until we have more than one type of retained regions), like this:
Possibly also put the regions count last, to keep the timings at the top. |
Thanks Stefan. I misunderstood, will update it as "Evacuation Failure Regions".
Currently, I implement it by add following phases:
and, add I tried to put a phase and work items under it in different log level, but seems the current phase time framework only support to log phase and its work items at the same log level. Maybe I missed something in the code, let me do some further investigation.
I tried this too. But seems the current phase time framework only support to put the WorkItems of a phase close to its phase, rather than separate them with other phases, I will investigate it further. |
I think you are correct, maybe Thomas know any trick. Otherwise I guess we could separate the "counts" from the timing, but that is not optimal either. If not solvable in a good way, maybe we should just drop some of the trace counts. |
There is no way to have different levels for the work items than for the timing it is attached to. I overlooked that when proposing this layout. I would like to just keep things the way they are though then, except moving the Making the work items having a different log level than the master item could be done later. One remark: that |
Not sure if I missed something in the code, but seems if "Evacuation Failed Regions" is attached to "Restore Retained Regions (ms)", then there is no way to put other phases between them.
Sure, I will update it as "Used Memory". :) |
close this one, new pr is at #6860 |
This is to get information about the pause time distribution (prepare(copy, sorting, …) , process (iterate) and cleanup) and region/objects/size statistics when processing evacuation failure objects in “Remove Self Forwards”, this information will be helpful when optimize the evacuation failure processing subsequently, and will also be helpful for users to analyze and troubleshoot in the future.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6763/head:pull/6763
$ git checkout pull/6763
Update a local copy of the PR:
$ git checkout pull/6763
$ git pull https://git.openjdk.java.net/jdk pull/6763/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6763
View PR using the GUI difftool:
$ git pr show -t 6763
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6763.diff