Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8279066: entries.remove(entry) is useless in PKCS12KeyStore #6910

Closed
wants to merge 2 commits into from
Closed

8279066: entries.remove(entry) is useless in PKCS12KeyStore #6910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6ee07
8279066: Still see private key entries without certificates in a PKCS…
wangweij Dec 21, 2021
844bf48
just ignore it
wangweij Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
View file
Open in desktop
Expand Up @@ -2265,11 +2265,6 @@ public synchronized void engineLoad(InputStream stream, char[] password)
/* Update existing KeyEntry in entries table */
if (chain.size() > 0) {
entry.chain = chain.toArray(new Certificate[chain.size()]);
} else {
// Remove private key entries where there is no associated
// certs. Most likely the keystore is loaded with a null
// password.
entries.remove(entry);
}
}
}
Expand Down