Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280054: BadSerializationTest and DragGestureEvent/DragGestureRecognizer constructors #7099

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jan 15, 2022

Please consider this enhancement to test/jdk/java/awt/dnd/BadSerializationTest/BadSerializationTest.java, which simplifies the process of manually generating serialized test data by using reflection to generate invalid instances of DragGestureEvent and DragGestureRecognizer, instead of relying on patching the constructors of those classes to disable validation checks.

This cleanup was proposed in the review for a possible fix for JDK-8277817: https://git.openjdk.java.net/jdk/pull/6603#issuecomment-997054470


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280054: BadSerializationTest and DragGestureEvent/DragGestureRecognizer constructors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7099/head:pull/7099
$ git checkout pull/7099

Update a local copy of the PR:
$ git checkout pull/7099
$ git pull https://git.openjdk.java.net/jdk pull/7099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7099

View PR using the GUI difftool:
$ git pr show -t 7099

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7099.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2022

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 15, 2022

@cushon The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cushon
Copy link
Contributor Author

cushon commented Mar 14, 2022

Closing due to lack of interest

@cushon cushon closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant