8280054: BadSerializationTest and DragGestureEvent/DragGestureRecognizer constructors #7099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this enhancement to
test/jdk/java/awt/dnd/BadSerializationTest/BadSerializationTest.java
, which simplifies the process of manually generating serialized test data by using reflection to generate invalid instances ofDragGestureEvent
andDragGestureRecognizer
, instead of relying on patching the constructors of those classes to disable validation checks.This cleanup was proposed in the review for a possible fix for JDK-8277817: https://git.openjdk.java.net/jdk/pull/6603#issuecomment-997054470
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7099/head:pull/7099
$ git checkout pull/7099
Update a local copy of the PR:
$ git checkout pull/7099
$ git pull https://git.openjdk.java.net/jdk pull/7099/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7099
View PR using the GUI difftool:
$ git pr show -t 7099
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7099.diff