Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy #7100

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jan 15, 2022

This change updates the serialized objects used by java/awt/dnd/BadSerializationTest/BadSerializationTest.java using a similar approach to the previous fix in JDK-8039082.

It also contains a fix for the subset of JDK-8278620 necessary for the test to pass with the updated serialized objects.

See also discussion in https://git.openjdk.java.net/jdk/pull/6603


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy
  • JDK-8278555: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7100/head:pull/7100
$ git checkout pull/7100

Update a local copy of the PR:
$ git checkout pull/7100
$ git pull https://git.openjdk.java.net/jdk pull/7100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7100

View PR using the GUI difftool:
$ git pr show -t 7100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7100.diff

…failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2022

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 15, 2022
@openjdk
Copy link

openjdk bot commented Jan 15, 2022

@cushon The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 15, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2022

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2022

@cushon This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant