Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" #7284

Closed
wants to merge 1 commit into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Jan 31, 2022

Focus painting for combo box and radio button with custom icon should honour the corresponding property.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes" ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7284/head:pull/7284
$ git checkout pull/7284

Update a local copy of the PR:
$ git checkout pull/7284
$ git pull https://git.openjdk.java.net/jdk pull/7284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7284

View PR using the GUI difftool:
$ git pr show -t 7284

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7284.diff

…Image Radio Buttons" and "Image CheckBoxes"

Make border painting for the check boxes and radio buttons with custom icons
take into account the property that enables or disables the focus painting.
Add that case to the test.
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 31, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

@azuev-java azuev-java closed this Jan 31, 2022
@azuev-java azuev-java deleted the JDK-8216358 branch Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant