New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8281309: x86: Select better stack banging instruction #7361
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Given the data is actually not needed anywhere, we could use non-temporal store |
At the first glance it seems to be a total win over the current method since it is the same, but without the drawback of cache pressure, so I think it would be beneficial to just replace the current one. |
6d1c330
to
1d41970
Compare
@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@shipilev This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
WIP.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7361/head:pull/7361
$ git checkout pull/7361
Update a local copy of the PR:
$ git checkout pull/7361
$ git pull https://git.openjdk.java.net/jdk pull/7361/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7361
View PR using the GUI difftool:
$ git pr show -t 7361
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7361.diff