Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281309: x86: Select better stack banging instruction #7361

Closed
wants to merge 6 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 7, 2022

WIP.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281309: x86: Select better stack banging instruction

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7361/head:pull/7361
$ git checkout pull/7361

Update a local copy of the PR:
$ git checkout pull/7361
$ git pull https://git.openjdk.java.net/jdk pull/7361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7361

View PR using the GUI difftool:
$ git pr show -t 7361

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7361.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Feb 7, 2022
@shipilev shipilev changed the title 8281309: x86: Use loads instead of stores for stack banging 8281309: x86: Select better stack banging instruction Feb 9, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2022

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@merykitty
Copy link
Member

Given the data is actually not needed anywhere, we could use non-temporal store movnti which will not mess up our cache.
Thanks

@merykitty
Copy link
Member

At the first glance it seems to be a total win over the current method since it is the same, but without the drawback of cache pressure, so I think it would be beneficial to just replace the current one.

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2022

@shipilev This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org
2 participants