Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277474: jarsigner does not check if algorithm parameters are disabled #7580

Closed
wants to merge 3 commits into from

Conversation

haimaychao
Copy link
Contributor

@haimaychao haimaychao commented Feb 22, 2022

This fixes jarsigner to enforce checking against algorithm constraint properties so when the signature algorithms parameters use disabled or legacy algorithms, it will emit warnings accordingly. If the algorithm used in parameters is disabled, jarsigner treats the jar as unsigned.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277474: jarsigner does not check if algorithm parameters are disabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7580/head:pull/7580
$ git checkout pull/7580

Update a local copy of the PR:
$ git checkout pull/7580
$ git pull https://git.openjdk.java.net/jdk pull/7580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7580

View PR using the GUI difftool:
$ git pr show -t 7580

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7580.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2022

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@haimaychao The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security core-libs compiler labels Feb 22, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2022

Webrevs

@haimaychao haimaychao closed this Feb 22, 2022
@haimaychao
Copy link
Contributor Author

haimaychao commented Feb 22, 2022

/label remove core-libs

@haimaychao
Copy link
Contributor Author

haimaychao commented Feb 22, 2022

/label remove compiler

@openjdk openjdk bot removed the core-libs label Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@haimaychao
The core-libs label was successfully removed.

@openjdk openjdk bot removed the compiler label Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@haimaychao
The compiler label was successfully removed.

@haimaychao
Copy link
Contributor Author

haimaychao commented Feb 22, 2022

/open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr security
1 participant