Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273042: TLS Certificate Compression #7599

Closed
wants to merge 8 commits into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Feb 23, 2022

Hi,

Please review the implementation of RFC 8879, TLS Certificate Compression, in JDK. The TLS Certificate Compression standard is an essential part for QUIC connections and performance improvement for TLS connections. More details, please refer to the JEP proposal.

The JEP was submitted, and it may take time for the final approval. But let me know you ideas and concerns about the proposal and implementation.

JEP: https://bugs.openjdk.java.net/browse/JDK-8281710


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7599/head:pull/7599
$ git checkout pull/7599

Update a local copy of the PR:
$ git checkout pull/7599
$ git pull https://git.openjdk.java.net/jdk pull/7599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7599

View PR using the GUI difftool:
$ git pr show -t 7599

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7599.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@XueleiFan The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Feb 23, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

this.name = name;
}

static CompressionAlgorithm nameOf(String name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be valueOf? We're not consistent in the method name across all our sun.security.ssl enumerations, but more often than not when we return the enumeration object it's via a valueOf call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...I take that back. Seems like when the input is a string we do go by nameOf. Maybe this is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see your points. valueOf(String) is a built-in method of enum, where the String input is not the one was expected for the nameOf(String) method. So nameOf() was used a lot in the SunJSSE provider implementation.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

@XueleiFan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2022

@XueleiFan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net net-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org
2 participants