New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8282411: Add useful predicates to ElementKind #7637
Conversation
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than unusual indentation in isExecutable and isInitializer, looks good. Thanks!
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 732d891. |
Discussion from a recent review in javadoc, adding some more functionality to ElementKind predicates.
Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282461
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7637/head:pull/7637
$ git checkout pull/7637
Update a local copy of the PR:
$ git checkout pull/7637
$ git pull https://git.openjdk.java.net/jdk pull/7637/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7637
View PR using the GUI difftool:
$ git pr show -t 7637
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7637.diff