Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8282411: Add useful predicates to ElementKind #7637

Closed
wants to merge 4 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Feb 28, 2022

Discussion from a recent review in javadoc, adding some more functionality to ElementKind predicates.

Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282461


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7637/head:pull/7637
$ git checkout pull/7637

Update a local copy of the PR:
$ git checkout pull/7637
$ git pull https://git.openjdk.java.net/jdk pull/7637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7637

View PR using the GUI difftool:
$ git pr show -t 7637

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7637.diff

@openjdk openjdk bot added the csr label Feb 28, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 28, 2022
@openjdk
Copy link

openjdk bot commented Feb 28, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Feb 28, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2022

Webrevs

@openjdk openjdk bot removed the csr label Mar 1, 2022
Copy link
Member

@pavelrappo pavelrappo left a comment

Other than unusual indentation in isExecutable and isInitializer, looks good. Thanks!

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282411: Add useful predicates to ElementKind

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 1, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Mar 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit 732d891.

@openjdk openjdk bot added the integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready rfr labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@jddarcy Pushed as commit 732d891.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler integrated
2 participants