Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255065: Zero: accessor_entry misses the IRIW case #766

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 20, 2020

While doing a change in related area, I noticed there is no IRIW handling block in ZeroInterpreter::accessor_entry when reading volatile fields. This probably breaks PPC64 Zero.

There is a block in bytecodeInterpreter.cpp for common field access:

          if (cache->is_volatile()) {
            if (support_IRIW_for_not_multiple_copy_atomic_cpu) {
              OrderAccess::fence();
            }

Attention @TheRealMDoerr ;)

Testing:

  • Linux x86_64 zero fastdebug build (includes jmod generation with Zero)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (5/9 failed) (2/9 failed) (1/9 failed)

Failed test tasks

Issue

  • JDK-8255065: Zero: accessor_entry misses the IRIW case

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/766/head:pull/766
$ git checkout pull/766

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 20, 2020
@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 20, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2020

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Good catch! I don't think anybody uses zero for PPC64, but it's better to get this fixed. Thanks.

@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255065: Zero: accessor_entry misses the IRIW case

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 856037c: 8255006: Add NULL-check to StringDedupTable lookup
  • ee6eb98: 8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized
  • e577c8c: 8253641: Missing newline in the printout of certain JFR events
  • 89e5444: 8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit
  • 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
  • cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
  • 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
  • f167a71: 8254264: Remove redundant cross_modify_fence()
  • 44f9271: 8254974: Fix stutter typo in TypeElement
  • 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/017d151e11619d42d37b24b8fe5982eb7787573c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2020
@shipilev
Copy link
Contributor Author

shipilev commented Oct 21, 2020

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@shipilev Since your change was applied there have been 47 commits pushed to the master branch:

  • 2a06335: 8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I"
  • 1b7ddeb: 8254976: Re-enable swing jtreg tests which were broken due to samevm mode
  • 2e510e0: 8255043: Incorrectly styled copyright text
  • 6bd05b1: 8255074: sun.nio.fs.WindowsPath::getPathForWin32Calls synchronizes on String object
  • 9e9f5e6: 8017179: [macosx] list1 and list2 vistble item isn't desired
  • 2ee2b4a: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • 42a6ead: 8254884: Make sure jvm does not crash with Arm SVE and Vector API
  • e5870cf: 8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active
  • afc967f: 8254783: jpackage fails on Windows when application name differs from installer name
  • 3ccf487: 8253019: Enhanced JPEG decoding
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/017d151e11619d42d37b24b8fe5982eb7787573c...master

Your commit was automatically rebased without conflicts.

Pushed as commit bd45191.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8255065-zero-accessor-iriw branch Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
2 participants