Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283937: riscv: RVC: Fix c_beqz to c_bnez #8034

Closed
wants to merge 1 commit into from

Conversation

zhengxiaolinX
Copy link
Contributor

@zhengxiaolinX zhengxiaolinX commented Mar 30, 2022

Hi team,

As the appointment (mentioned in #7982 ), submit another PR for reviews.

This patch fixes a typo introduced in JDK-8278994: c_bnez is mistakenly written to c_beqz, though not used until now, needing a fix for future usage.

Thanks,
Xiaolin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8034/head:pull/8034
$ git checkout pull/8034

Update a local copy of the PR:
$ git checkout pull/8034
$ git pull https://git.openjdk.java.net/jdk pull/8034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8034

View PR using the GUI difftool:
$ git pr show -t 8034

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8034.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@zhengxiaolinX The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@zhengxiaolinX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283937: riscv: RVC: Fix c_beqz to c_bnez

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022
@zhengxiaolinX
Copy link
Contributor Author

Thanks again for the review! @shipilev

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@zhengxiaolinX
Your change (at version 727c1f2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

The affected instruction does not seem to be used anywhere, and the change is trivially correct. I'll sponsor now.

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit 720e751.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 51c05e8: 8282764: AArch64: compiler/vectorapi/reshape/TestVectorCastNeon.java failed with incorrect result

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@shipilev @zhengxiaolinX Pushed as commit 720e751.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengxiaolinX zhengxiaolinX deleted the rvc-fix branch March 30, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants