New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283937: riscv: RVC: Fix c_beqz to c_bnez #8034
Conversation
👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into |
@zhengxiaolinX The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@zhengxiaolinX This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks again for the review! @shipilev /integrate |
@zhengxiaolinX |
The affected instruction does not seem to be used anywhere, and the change is trivially correct. I'll sponsor now. /sponsor |
@shipilev @zhengxiaolinX Pushed as commit 720e751. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi team,
As the appointment (mentioned in #7982 ), submit another PR for reviews.
This patch fixes a typo introduced in JDK-8278994:
c_bnez
is mistakenly written toc_beqz
, though not used until now, needing a fix for future usage.Thanks,
Xiaolin
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8034/head:pull/8034
$ git checkout pull/8034
Update a local copy of the PR:
$ git checkout pull/8034
$ git pull https://git.openjdk.java.net/jdk pull/8034/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8034
View PR using the GUI difftool:
$ git pr show -t 8034
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8034.diff