Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277816: Client tests fail on macos-Aarch64 host #8216

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 13, 2022

This tests was failing on macos12 M1 systems due to wrong color profile configurations set in CI systems.
If correct sRGB IEC61966-2.1 is set, then these test passed. Test job link in JBS..

So, removing from Problem list..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8216/head:pull/8216
$ git checkout pull/8216

Update a local copy of the PR:
$ git checkout pull/8216
$ git pull https://git.openjdk.java.net/jdk pull/8216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8216

View PR using the GUI difftool:
$ git pr show -t 8216

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8216.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prsadhuk
Copy link
Contributor Author

/label add client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@prsadhuk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277816: Client tests fail on macos-Aarch64 host

Reviewed-by: serb, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

  • 339005d: 8284816: Make markWord::has_monitor() more robust
  • 2ba5cc4: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
  • c3938ec: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • 23c6817: 6626492: Event time in future part 2, now on X
  • 2241a05: 8284578: Relax InterpreterCodelet stub alignment
  • bf85b00: 8284564: Extend VectorAPI validation tests for SHIFTs and ROTATE operations with constant shift values.
  • bf1c3ef: 8284775: Simplify String.substring(_, length()) calls
  • 249d54f: 8284673: Collapse identical catch branches in java.management
  • c7755b8: 8283094: Add Ideal transformation: x + (con - y) -> (x - y) + con
  • e245f9d: 8284274: Error reporting crashes because missing ResourceMarks
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/ec73c61d8fe5de15a42fc14aaf8ebe3ac9ffcae5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

Going to push as commit 994a439.
Since your change was applied there have been 169 commits pushed to the master branch:

  • 9098343: 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill
  • d6b5a63: 8284908: Refine diagnostic positions for DCErroneous
  • fa04d1f: 8284949: riscv: Add Zero support for the 32-bit RISC-V architecture
  • 994f2e9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
  • 691c5da: 8285266: compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java fails after JDK-8284563
  • 94afb36: 8285093: Introduce UTIL_ARG_WITH
  • 8543aaa: 8283839: [JVMCI] add support for querying indy bootstrap method target and arguments
  • 81a8e2f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • 05ae7ed: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11
  • b2c33f0: 8282120: optimal capacity tests and test library need to be cleaned up
  • ... and 159 more: https://git.openjdk.java.net/jdk/compare/ec73c61d8fe5de15a42fc14aaf8ebe3ac9ffcae5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2022
@openjdk openjdk bot closed this Apr 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@prsadhuk Pushed as commit 994a439.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8277816 branch April 21, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants