Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment #8446

Closed
wants to merge 6 commits into from
Closed

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment #8446

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23f584b
Do not call JavaThread::thread_from_jni_environment
parttimenerd Apr 14, 2022
28180bc
Use JavaThread::current_or_null
parttimenerd Apr 14, 2022
1e2885e
Use Thread::current_or_null_safe() and add comments
parttimenerd Apr 28, 2022
e77e466
Use JavaThread::cast
parttimenerd May 3, 2022
8d4b60e
Merge cast into condition
parttimenerd May 3, 2022
48f45e9
Break long line
parttimenerd May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/hotspot/share/prims/forte.cpp
View file
Open in desktop
Expand Up @@ -563,10 +563,9 @@ extern "C" {
JNIEXPORT
void AsyncGetCallTrace(ASGCT_CallTrace *trace, jint depth, void* ucontext) {

JavaThread* thread;
JavaThread* thread = JavaThread::current_or_null();
parttimenerd marked this conversation as resolved.
Show resolved Hide resolved

if (trace->env_id == NULL ||
(thread = JavaThread::thread_from_jni_environment(trace->env_id))->is_exiting()) {
if (trace->env_id == NULL || thread == NULL || thread->is_terminated() || thread->is_exiting()) {
parttimenerd marked this conversation as resolved.
Show resolved Hide resolved
// bad env_id, thread has exited or thread is exiting
trace->num_frames = ticks_thread_exit; // -8
return;
Expand All @@ -578,7 +577,7 @@ void AsyncGetCallTrace(ASGCT_CallTrace *trace, jint depth, void* ucontext) {
return;
}

assert(JavaThread::current() == thread,
assert(thread == JavaThread::thread_from_jni_environment(trace->env_id),
parttimenerd marked this conversation as resolved.
Show resolved Hide resolved
"AsyncGetCallTrace must be called by the current interrupted thread");

if (!JvmtiExport::should_post_class_load()) {
Expand Down