-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows #873
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please asks @prrace for any details about the test failures, it looks like we do not have any logs/stacktraces.
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 17 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4acf634. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a test fix for an issue seen to be failing in mach5 testing. Although initially the failure was reported on windows, it is problemlisted only for mac.
It seems to be a timing issue resulting in failure in mach5 macos systems so added a delay after the frame setVisible is called. Also, moved the frame to centre of screen to be consistent with other tests.
Mach5 job has been run for several iterations in all platforms. Link in JBS.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/873/head:pull/873
$ git checkout pull/873