8286855: javac error on invalid jar should only print filename

[RealCLanger]

As was suggested in the review for JDK-8286444, javac should always print the filename only, when encountering a ZipException.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286855: javac error on invalid jar should only print filename

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8900/head:pull/8900
$ git checkout pull/8900

Update a local copy of the PR:
$ git checkout pull/8900
$ git pull https://git.openjdk.java.net/jdk pull/8900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8900

View PR using the GUI difftool:
$ git pr show -t 8900

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8900.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cb441db3)

[TheRealMDoerr]

Ok, that was discussed in #8616. I agree with your assessment that printing the full path should not really be problematic, but printing the file name only should be sufficient.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286855: javac error on invalid jar should only print filename

Reviewed-by: jpai, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• b1b9674: 8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet
• eb8d067: 8287433: [PPC64] g1_write_barrier_pre needs extension for Loom
• d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
• 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
• 1b9987c: 8287288: Fix some typos in C1
• 447ae00: 8287418: riscv: Fix correctness issue of MacroAssembler::movptr
• a27ba1a: 8287363: null pointer should use NULL instead of 0
• 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
• 5848a60: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"
• 3d2d039: 8287440: Typo in package-info.java of java.util.random
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/f58c9a659ba181407ecdb2aacb81e6a7f1cbd9ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit 1606d55.
Since your change was applied there have been 37 commits pushed to the master branch:

• f086d94: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
• 73ba7fd: 8287157: Clean up G1Policy::next_gc_should_be_mixed()
• b1b9674: 8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet
• eb8d067: 8287433: [PPC64] g1_write_barrier_pre needs extension for Loom
• d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
• 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
• 1b9987c: 8287288: Fix some typos in C1
• 447ae00: 8287418: riscv: Fix correctness issue of MacroAssembler::movptr
• a27ba1a: 8287363: null pointer should use NULL instead of 0
• 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/f58c9a659ba181407ecdb2aacb81e6a7f1cbd9ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 1606d55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.