Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8255603: Memory/Performance regression after JDK-8210985 #937

Closed
wants to merge 2 commits into from
Closed

JDK-8255603: Memory/Performance regression after JDK-8210985 #937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049c1c0
JDK-8255603: Memory/Performance regression after JDK-8210985
RealCLanger Oct 29, 2020
4b44648
Copyright year
RealCLanger Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/java.base/share/classes/sun/security/util/Cache.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2011, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -265,8 +265,7 @@ public MemoryCache(boolean soft, int maxSize, int lifetime) {
else
this.queue = null;

int buckets = (int)(maxSize / LOAD_FACTOR) + 1;
cacheMap = new LinkedHashMap<>(buckets, LOAD_FACTOR, true);
cacheMap = new LinkedHashMap<>(1, LOAD_FACTOR, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. The idea of scaling the initial cache size to the maximum size seems obviously to be wrong.

}

/**
Expand Down