Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251177: [macosx] The text "big" is truncated #984

Closed
wants to merge 3 commits into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Nov 1, 2020

The manual test creates a JTabbedPane and add tabs with text with different html styles. For the tab with text "big", a bigger text size is used and it is expected that this should result in making the tab height bigger.

For AquaLookAndFeel, inside class AquaJTabbedPaneUI and AquaTabbedPaneCopyFromBasicUI, the tabs height is constraint and there is upper/lower limit set for tab height. So the tab height is less than expected and the text looks truncated. I do not see this issue in other L&Fs.

It looks like this is done deliberately for AquaL&F and this is not a bug. but the test instructions do not specify this and result in confusion. So updating the test instructions to specify that the text "big" may be truncated in MacOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk pull/984/head:pull/984
$ git checkout pull/984

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2020

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2020

@pankaj-bansal The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Nov 1, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2020
@pankaj-bansal pankaj-bansal changed the title 8251177: [macosx] The text big is truncated 8251177: [macosx] The text "big" is truncated Nov 1, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2020

Webrevs

@mrserb
Copy link
Member

mrserb commented Nov 1, 2020

Probably it is better to limit the size of the font?

@pankaj-bansal
Copy link
Author

Probably it is better to limit the size of the font?

Ok, I have reduced the font size. Now the text size if such that it is bigger than other texts, but text would fit within the tab height and text is not truncated.

@mrserb
Copy link
Member

mrserb commented Nov 2, 2020

I meant to limit the font size in the tab-pane.

@pankaj-bansal
Copy link
Author

I meant to limit the font size in the tab-pane.

ok, just for clarification, you mean this should be fixed as product bug not test issue? We should limit the font size in AquaJTabbedPaneUI, so that the text is not truncated?

@mrserb
Copy link
Member

mrserb commented Nov 2, 2020

I meant to limit the font size in the tab-pane.

ok, just for clarification, you mean this should be fixed as product bug not test issue? We should limit the font size in AquaJTabbedPaneUI, so that the text is not truncated?

Yes something like that in the JDK itself, I remember that menu items in the menubar on windows behave in a similar way, ignore the font size bigger some value.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2020

@pankaj-bansal This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@prrace
Copy link
Contributor

prrace commented Dec 12, 2020

If this fix is going to be done differently and isn't coming soon, can you withdraw the PR until it is ready

@pankaj-bansal pankaj-bansal deleted the JDK-8251177 branch May 3, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review swing client-libs-dev@openjdk.org
3 participants