Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID #9929

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Aug 18, 2022

Change problem listing to use the correct issue ID.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9929/head:pull/9929
$ git checkout pull/9929

Update a local copy of the PR:
$ git checkout pull/9929
$ git pull https://git.openjdk.org/jdk pull/9929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9929

View PR using the GUI difftool:
$ git pr show -t 9929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9929.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@bplb To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@bplb
Copy link
Member Author

bplb commented Aug 19, 2022

/label add nio

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@bplb
The nio label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 19, 2022

Webrevs

@jaikiran
Copy link
Member

I've now added a problemlist label to JDK-8233437 as suggested in the ProblemListing section of the manual https://openjdk.org/guide/.

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
  • 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
  • a1df2da: 8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."
  • 1b756bf: 8236048: Cleanup use of Utils.normalizeNewlines
  • 97e2689: 8288121: [JVMCI] Re-export the TerminatingThreadLocal functionality to the graal compiler.
  • 833bf06: 8292608: [AIX] Broken build after 8291945
  • 62a7fc6: 8292315: Tests should not rely on specific JAR file names (hotspot)
  • 20a3cb7: 8292488: JFR: Incorrect comment in ActiveRecordingEvent
  • f567fa0: 8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"
  • ... and 7 more: https://git.openjdk.org/jdk/compare/494d3873b1d0f7e3ca0a063b44362e7242298dec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2022
@bplb
Copy link
Member Author

bplb commented Aug 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 5ca268c.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
  • f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
  • 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • 2edd550: 8292312: Work around memset() called operator new
  • 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
  • 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
  • ... and 14 more: https://git.openjdk.org/jdk/compare/494d3873b1d0f7e3ca0a063b44362e7242298dec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@bplb Pushed as commit 5ca268c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb
Copy link
Member Author

bplb commented Aug 19, 2022

I've now added a problemlist label to JDK-8233437 as suggested in the ProblemListing section of the manual https://openjdk.org/guide/.

Thanks, I missed that.

@bplb bplb deleted the DatagramChannel-Unref-8292636 branch September 1, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants