Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249623: test @ignore-d due to 7013634 should be returned back to execution #1212

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 11, 2022

This is a backport of JDK-8249623 to prepare for backporting
JDK-8253916. I had to resolve resexhausted001\TestDescription.java
and the problemlist entries a little bit.

The entries for JDK-7013634 had originally been removed by two test cleanup commits,
e.g. (openjdk/jdk12@996ecff) and
(openjdk/jdk12@6a4f482) after JDK-7013634
had been closed as not reproducible.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1212/head:pull/1212
$ git checkout pull/1212

Update a local copy of the PR:
$ git checkout pull/1212
$ git pull https://git.openjdk.org/jdk11u-dev pull/1212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1212

View PR using the GUI difftool:
$ git pr show -t 1212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1212.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd33abb136d415455090cef4fe6211d9e6940948 8249623: test @ignore-d due to 7013634 should be returned back to execution Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

@RealCLanger RealCLanger force-pushed the RealCLanger-backport-cd33abb1 branch from 61c17c8 to 0af9e1b Compare July 15, 2022 06:47
@RealCLanger RealCLanger changed the base branch from master to pr/1229 July 15, 2022 06:47
@openjdk-notifier
Copy link

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1229 to master July 19, 2022 08:12
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout RealCLanger-backport-cd33abb1
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249623: test @ignore-d due to 7013634 should be returned back to execution

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2dc4088: 8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes
  • 5e1ce54: 8288763: Pack200 extraction failure with invalid size
  • c63209b: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
  • 4b45646: 8285081: Improve XPath operators count accuracy
  • 6496396: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • e02ab45: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5
  • a10ef71: 8286177: C2: "failed: non-reduction loop contains reduction nodes" assert failure
  • 39eecbf: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
  • 8486da7: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
  • a9c27da: 8236490: Compiler bug relating to @nonnull annotation
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/9c6fce30d13138ebdccf597b7034ca0413f125ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2022
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit 805a031.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 2dc4088: 8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes
  • 5e1ce54: 8288763: Pack200 extraction failure with invalid size
  • c63209b: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
  • 4b45646: 8285081: Improve XPath operators count accuracy
  • 6496396: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • e02ab45: 8286211: Update PCSC-Lite for Suse Linux to 1.9.5
  • a10ef71: 8286177: C2: "failed: non-reduction loop contains reduction nodes" assert failure
  • 39eecbf: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
  • 8486da7: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
  • a9c27da: 8236490: Compiler bug relating to @nonnull annotation
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/9c6fce30d13138ebdccf597b7034ca0413f125ca...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@RealCLanger Pushed as commit 805a031.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-cd33abb1 branch July 19, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants