-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249623: test @ignore-d due to 7013634 should be returned back to execution #1212
8249623: test @ignore-d due to 7013634 should be returned back to execution #1212
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
61c17c8
to
0af9e1b
Compare
@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout RealCLanger-backport-cd33abb1
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 805a031.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 805a031. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of JDK-8249623 to prepare for backporting
JDK-8253916. I had to resolve resexhausted001\TestDescription.java
and the problemlist entries a little bit.
The entries for JDK-7013634 had originally been removed by two test cleanup commits,
e.g. (openjdk/jdk12@996ecff) and
(openjdk/jdk12@6a4f482) after JDK-7013634
had been closed as not reproducible.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1212/head:pull/1212
$ git checkout pull/1212
Update a local copy of the PR:
$ git checkout pull/1212
$ git pull https://git.openjdk.org/jdk11u-dev pull/1212/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1212
View PR using the GUI difftool:
$ git pr show -t 1212
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1212.diff