Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257722: Improve "keytool -printcert -jarfile" output #1495

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 3, 2022

I backport this for parity with 11.0.18-oracle.

src/java.base/share/classes/sun/security/tools/keytool/Main.java
had to be resolved:
In 11, x.getSubjectDN() is printed to 'out'. In the original
change and in 17, x.getSubjectX500Principal() is printed in this
place.
This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11.

I also had to resolve
src/java.base/share/classes/sun/security/tools/keytool/Resources.java
due to context.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257722: Improve "keytool -printcert -jarfile" output

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1495/head:pull/1495
$ git checkout pull/1495

Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/jdk11u-dev pull/1495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1495

View PR using the GUI difftool:
$ git pr show -t 1495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1495.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport de93b1d0e83a9428dae4a9609996fe7b7e9b4932 8257722: Improve "keytool -printcert -jarfile" output Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257722: Improve "keytool -printcert -jarfile" output

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 91f1538: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 4, 2022

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 13c07e6.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 7c5f9c6: 8295429: Update harfbuzz md file
  • 3b40d21: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • 182173a: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 91f1538: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@GoeLin GoeLin deleted the goetz_backport_8257722 branch November 4, 2022 07:54
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@GoeLin Pushed as commit 13c07e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants