-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257722: Improve "keytool -printcert -jarfile" output #1495
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! /integrate |
Going to push as commit 13c07e6.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.18-oracle.
src/java.base/share/classes/sun/security/tools/keytool/Main.java
had to be resolved:
In 11, x.getSubjectDN() is printed to 'out'. In the original
change and in 17, x.getSubjectX500Principal() is printed in this
place.
This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11.
I also had to resolve
src/java.base/share/classes/sun/security/tools/keytool/Resources.java
due to context.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1495/head:pull/1495
$ git checkout pull/1495
Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/jdk11u-dev pull/1495/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1495
View PR using the GUI difftool:
$ git pr show -t 1495
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1495.diff