Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293834: Update CLDR data following tzdata 2022c update #1567

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 6, 2022

This patch updates the CLDR data following the tzdata bump in JDK-8292579.

This will be handled in trunk by a larger update to CLDRv42.

It differs from the 17u version slightly in the bug ID line in the test, as 11u lacks JDK-8261279, but is otherwise clean and the updated test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293834: Update CLDR data following tzdata 2022c update

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1567/head:pull/1567
$ git checkout pull/1567

Update a local copy of the PR:
$ git checkout pull/1567
$ git pull https://git.openjdk.org/jdk11u-dev pull/1567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1567

View PR using the GUI difftool:
$ git pr show -t 1567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1567.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e10231248fc100f9dfa08468ac897f60b843857f 8293834: Update CLDR data following tzdata 2022c update Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 6, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293834: Update CLDR data following tzdata 2022c update

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2022
@gnu-andrew
Copy link
Member Author

I see jdk11u-fix-yes

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit 87c8450.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@gnu-andrew Pushed as commit 87c8450.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants