-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253899: Make IsClassUnloadingEnabled signature match specification #16
Conversation
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/csr needed |
@VladimirKempik the issue for this pull request, JDK-8253899, already has an approved CSR request: JDK-8254014 |
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 69 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Martin, I will await until csr for this backport is approved before going for jdk11u approval |
/integrate |
Going to push as commit d7a6e51.
Your commit was automatically rebased without conflicts. |
@VladimirKempik Pushed as commit d7a6e51. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean backport of 8253899 to jdk11u-dev. The testcase got different filename extension (c, not cpp), that had to be corrected.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/16/head:pull/16
$ git checkout pull/16
Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/16/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16
View PR using the GUI difftool:
$ git pr show -t 16
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/16.diff