Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253899: Make IsClassUnloadingEnabled signature match specification #16

Closed
wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jun 4, 2021

Almost clean backport of 8253899 to jdk11u-dev. The testcase got different filename extension (c, not cpp), that had to be corrected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253899: Make IsClassUnloadingEnabled signature match specification

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/16.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c7f00640627eab38b77d23d07876cf0247fa18f3 8253899: Make IsClassUnloadingEnabled signature match specification Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 4, 2021
@VladimirKempik
Copy link
Author

/csr needed

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@VladimirKempik the issue for this pull request, JDK-8253899, already has an approved CSR request: JDK-8254014

@mlbridge
Copy link

mlbridge bot commented Jun 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253899: Make IsClassUnloadingEnabled signature match specification

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2021
@VladimirKempik
Copy link
Author

VladimirKempik commented Jul 14, 2021

Thanks Martin, I will await until csr for this backport is approved before going for jdk11u approval

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

Going to push as commit d7a6e51.
Since your change was applied there have been 124 commits pushed to the master branch:

  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • 2b3a641: 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases
  • ... and 114 more: https://git.openjdk.java.net/jdk11u-dev/compare/5c35022bacc55400ba27ca2e49a803c2326c195d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2021
@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@VladimirKempik Pushed as commit d7a6e51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants