Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #1684

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 24, 2023

I backport this for parity with 11.0.19-oracle.

The patch to ProblemList did not apply. The test ist problemlisted for
Solaris, but not for this issue.

Further, LingeredApp.startApp() has different argument requirements.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
  • JDK-8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1684/head:pull/1684
$ git checkout pull/1684

Update a local copy of the PR:
$ git checkout pull/1684
$ git pull https://git.openjdk.org/jdk11u-dev pull/1684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1684

View PR using the GUI difftool:
$ git pr show -t 1684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1684.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 99a6c47855ad82e81a80726cf3aa4522c547716d 8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 25, 2023

Pre-submit failure: test SuspendAtExit timed out. Known spurious issue. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2023

Going to push as commit b88cd77.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 9d7bb60: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
  • 65180f1: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
  • 7e74421: 8286962: java/net/httpclient/ServerCloseTest.java failed once with ConnectException
  • ebac392: 8300742: jstat's CGCT is 5 percent higher than the pause time in -Xlog:gc.
  • fc4b9de: 8218431: Improved platform checking in makefiles
  • 6ffd006: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
  • f5a04fb: 8299194: CustomTzIDCheckDST.java may fail at future date
  • acedbcb: 8299296: Write a test to verify the components selection sends ItemEvent
  • 37a15a1: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
  • 8547c80: 8300773: Address the inconsistency between the constant array and pool size
  • ... and 22 more: https://git.openjdk.org/jdk11u-dev/compare/c9ce60b9d0b36ed9e563745dd219dd7a438149ac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2023
@openjdk openjdk bot closed this Feb 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2023
@GoeLin GoeLin deleted the goetz_backport_8298073 branch February 8, 2023 16:08
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@GoeLin Pushed as commit b88cd77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants