-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros #1740
8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros #1740
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 06ee0b6.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 06ee0b6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8297963, commit 1a38e26e from the openjdk/jdk17u-dev repository.
The commit being backported was authored by Ben Taylor on 27 Jan 2023 and had no reviewers.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1740/head:pull/1740
$ git checkout pull/1740
Update a local copy of the PR:
$ git checkout pull/1740
$ git pull https://git.openjdk.org/jdk11u-dev pull/1740/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1740
View PR using the GUI difftool:
$ git pr show -t 1740
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1740.diff