8244508: JFR: FlightRecorderOptions reset date format #2121

pushkarnk · 2023-09-05T11:07:20Z

Hello all,

This backport request is related to JDK-8244508 [1]. When using JFR (-XX:StartFlightRecording), the configured default Locale is not honored, with FormatData or TimezoneNames(for example), because the relevant ResourceBundles do not get loaded when an attempt is made to locate and load them during VM startup (i.e when -XX:StartFlightRecording triggers JFR initialiazation). Though [1] quotes a mailing-list post [2] mentioning this issue was not seen with jdk11 then, the testcase in [1] does fail with 11.0.20 (as well as 11.0.22/master branch) as of today:

$ java --show-version -Duser.country=DE -Duser.language=de -XX:FlightRecorderOptions=stackdepth=128 Main
openjdk 11.0.22-internal 2024-01-16
OpenJDK Runtime Environment (build 11.0.22-internal+0-adhoc.pushkarnk.jdk11u-dev)
OpenJDK 64-Bit Server VM (build 11.0.22-internal+0-adhoc.pushkarnk.jdk11u-dev, mixed mode)
expected: 01.01.2020, 00:00:00
actual:   2020 Jan 1 00:00:00

Testing: Linux x86-64 build, tier1 tests with release and fastdebug builds.

[1] https://bugs.openjdk.org/browse/JDK-8244508
[2] https://mail.openjdk.org/pipermail/hotspot-jfr-dev/2020-March/001313.html

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8244508 needs maintainer approval

Issue

JDK-8244508: JFR: FlightRecorderOptions reset date format (Bug - P3 - Approved)

Reviewers

Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2121/head:pull/2121
$ git checkout pull/2121

Update a local copy of the PR:
$ git checkout pull/2121
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2121

View PR using the GUI difftool:
$ git pr show -t 2121

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2121.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-09-05T11:08:29Z

Hi @pushkarnk, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pushkarnk" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2023-09-05T11:10:14Z

This backport pull request has now been updated with issue from the original commit.

pushkarnk · 2023-09-05T11:32:10Z

/covered

mlbridge · 2023-09-07T15:07:41Z

Webrevs

00: Full (ff143291)

pushkarnk · 2023-09-16T16:35:22Z

Hello Maintainers,

Apologies for the ping. I was hoping to get some feedback on this backport request. Thanks!

pushkarnk · 2023-09-25T17:43:07Z

Hello Maintainers,

Apologies for the ping. I was hoping to get some feedback on this backport request. Please do let me know if there are questions. cc @RealCLanger @GoeLin

bridgekeeper · 2023-10-24T01:27:11Z

@pushkarnk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

pushkarnk · 2023-10-25T17:35:11Z

@pushkarnk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

I'd appreciate feedback on this backport request. Thank you.

RealCLanger · 2023-10-25T20:44:11Z

Hi @pushkarnk,

I think this backport is appropriate. Can you please run Github Actions verification? (E.g. enable actions here: https://github.com/pushkarnk/jdk11u-dev/actions and then merge the PR with master).

Furthermore, I'm wondering why the backport is not marked as clean. What did you have to resolve?

Cheers
Christoph

pushkarnk · 2023-10-27T04:12:37Z

/issue JDK-8244508

openjdk · 2023-10-27T04:13:12Z

@pushkarnk This issue is referenced in the PR title - it will now be updated.

pushkarnk · 2023-10-27T04:17:13Z

Hi @RealCLanger,

I've run the checks.

The original commit removed an unused import in DCmdConfigure.java which does not exist in jdk11. That's the only conflict I had to resolve.

Thanks!
~ Pushkar

RealCLanger · 2023-10-27T08:10:13Z

OK, looks good. I'll run the backport through our tests and will approve when no regressions spotted.

pushkarnk · 2023-11-08T09:58:27Z

OK, looks good. I'll run the backport through our tests and will approve when no regressions spotted.

Hi @RealCLanger, any news on this?

RealCLanger

Oh, sorry and thanks for the ping. I completely forgot about this. Tests are looking good.

openjdk · 2023-11-08T13:44:40Z

⚠️ @pushkarnk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

pushkarnk · 2023-11-16T11:00:29Z

/approval request

openjdk · 2023-11-16T11:02:17Z

@pushkarnk
8244508: The approval request has been created successfully.

RealCLanger · 2023-11-17T10:49:44Z

/approval request

@pushkarnk, you are supposed to also add some comment as part of the approval request to provide the maintainers some information. That includes some reasoning why you want this backport plus a risk assessment and information about the testing you did. So, please update or re-issue the /approval command with some text. Thx.

GoeLin · 2023-11-17T13:44:13Z

/approve yes

openjdk · 2023-11-17T13:46:37Z

@GoeLin
8244508: The approval request has been approved.

openjdk · 2023-11-17T13:48:55Z

⚠️ @pushkarnk the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8244508-fix
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

openjdk · 2023-11-17T13:49:00Z

@pushkarnk This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244508: JFR: FlightRecorderOptions reset date format

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
046b213: 8268916: Tests for AffirmTrust roots
5a7b227: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
1b6ff86: 8260035: Deproblemlist few problemlisted test
4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
5d14b13: 8275333: Print count in "Too many recored phases?" assert
27bfce0: 8210265: Crash in HSpaceCounters::update_used()
2b9d54a: 8306134: Open source some AWT tests relating to Button and a few other classes
a2ef248: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
... and 141 more: https://git.openjdk.org/jdk11u-dev/compare/5327f67b9e40ad756c6616779f3a2a44cdd257f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

pushkarnk · 2023-11-20T11:07:51Z

/approval request

@pushkarnk, you are supposed to also add some comment as part of the approval request to provide the maintainers some information. That includes some reasoning why you want this backport plus a risk assessment and information about the testing you did. So, please update or re-issue the /approval command with some text. Thx.

Thanks Chris. I guess this backport request has been approved now. I'll keep this in mind for all future work.

pushkarnk · 2023-11-20T11:11:56Z

I requested for this backport because an Ubuntu user reported this bug of JFR not honoring a configured default Locale. Locally, I ran the tier1 tests on Linux x86-64 with release and fastdebug builds.

pushkarnk · 2023-11-20T11:12:19Z

/integrate

RealCLanger · 2023-11-20T12:57:42Z

/sponsor

openjdk · 2023-11-20T12:58:23Z

@RealCLanger The change author (@pushkarnk) must issue an integrate command before the integration can be sponsored.

pushkarnk · 2023-11-20T13:37:11Z

/integrate

openjdk · 2023-11-20T13:39:32Z

@pushkarnk
Your change (at version ff14329) is now ready to be sponsored by a Committer.

RealCLanger · 2023-11-20T14:25:08Z

Weird that it didn't take your initial /integrate. So be it.

/sponsor

openjdk · 2023-11-20T14:50:46Z

Going to push as commit 7814102.
Since your change was applied there have been 151 commits pushed to the master branch:

10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
046b213: 8268916: Tests for AffirmTrust roots
5a7b227: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
1b6ff86: 8260035: Deproblemlist few problemlisted test
4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
5d14b13: 8275333: Print count in "Too many recored phases?" assert
27bfce0: 8210265: Crash in HSpaceCounters::update_used()
2b9d54a: 8306134: Open source some AWT tests relating to Button and a few other classes
a2ef248: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
... and 141 more: https://git.openjdk.org/jdk11u-dev/compare/5327f67b9e40ad756c6616779f3a2a44cdd257f7...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-11-20T14:52:28Z

@RealCLanger @pushkarnk Pushed as commit 7814102.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport f351901

ff14329

bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 5, 2023

openjdk bot changed the title ~~Backport f3519016c7766934d0aa3014b1a0593d91a0556c~~ 8244508: JFR: FlightRecorderOptions reset date format Sep 5, 2023

openjdk bot added the backport label Sep 5, 2023

bridgekeeper bot removed the oca Needs verification of OCA signatory status label Sep 7, 2023

openjdk bot added the rfr Pull request is ready for review label Sep 7, 2023

RealCLanger approved these changes Nov 8, 2023

View reviewed changes

openjdk bot added the approval label Nov 16, 2023

openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 17, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 20, 2023

openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023

openjdk bot closed this Nov 20, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8244508: JFR: FlightRecorderOptions reset date format #2121

8244508: JFR: FlightRecorderOptions reset date format #2121

pushkarnk commented Sep 5, 2023 •

edited by openjdk bot

bridgekeeper bot commented Sep 5, 2023

openjdk bot commented Sep 5, 2023

pushkarnk commented Sep 5, 2023 •

edited

mlbridge bot commented Sep 7, 2023

pushkarnk commented Sep 16, 2023

pushkarnk commented Sep 25, 2023

bridgekeeper bot commented Oct 24, 2023

pushkarnk commented Oct 25, 2023

RealCLanger commented Oct 25, 2023

pushkarnk commented Oct 27, 2023

openjdk bot commented Oct 27, 2023

pushkarnk commented Oct 27, 2023 •

edited

RealCLanger commented Oct 27, 2023

pushkarnk commented Nov 8, 2023

RealCLanger left a comment

openjdk bot commented Nov 8, 2023

pushkarnk commented Nov 16, 2023

openjdk bot commented Nov 16, 2023

RealCLanger commented Nov 17, 2023

GoeLin commented Nov 17, 2023

openjdk bot commented Nov 17, 2023

openjdk bot commented Nov 17, 2023

openjdk bot commented Nov 17, 2023 •

edited

pushkarnk commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

RealCLanger commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

RealCLanger commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

8244508: JFR: FlightRecorderOptions reset date format #2121

8244508: JFR: FlightRecorderOptions reset date format #2121

Conversation

pushkarnk commented Sep 5, 2023 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 5, 2023

openjdk bot commented Sep 5, 2023

pushkarnk commented Sep 5, 2023 • edited

mlbridge bot commented Sep 7, 2023

Webrevs

pushkarnk commented Sep 16, 2023

pushkarnk commented Sep 25, 2023

bridgekeeper bot commented Oct 24, 2023

pushkarnk commented Oct 25, 2023

RealCLanger commented Oct 25, 2023

pushkarnk commented Oct 27, 2023

openjdk bot commented Oct 27, 2023

pushkarnk commented Oct 27, 2023 • edited

RealCLanger commented Oct 27, 2023

pushkarnk commented Nov 8, 2023

RealCLanger left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 8, 2023

pushkarnk commented Nov 16, 2023

openjdk bot commented Nov 16, 2023

RealCLanger commented Nov 17, 2023

GoeLin commented Nov 17, 2023

openjdk bot commented Nov 17, 2023

openjdk bot commented Nov 17, 2023

openjdk bot commented Nov 17, 2023 • edited

pushkarnk commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

RealCLanger commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

pushkarnk commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

RealCLanger commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

openjdk bot commented Nov 20, 2023

pushkarnk commented Sep 5, 2023 •

edited by openjdk bot

pushkarnk commented Sep 5, 2023 •

edited

pushkarnk commented Oct 27, 2023 •

edited

openjdk bot commented Nov 17, 2023 •

edited