Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges #2128

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 13, 2023

Hi all,

This pull request contains a backport of JDK-8314094, commit 69c9ec92 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 5 Sep 2023 and was reviewed by Matthias Baesken and Arno Zeller.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2128/head:pull/2128
$ git checkout pull/2128

Update a local copy of the PR:
$ git checkout pull/2128
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2128

View PR using the GUI difftool:
$ git pr show -t 2128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2128.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 69c9ec92d04a399946b2157690a1dc3fec517329 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Sep 14, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@GoeLin Only integrators for this repository are allowed to issue the /approve command.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

Going to push as commit 94c048f.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 22dd2d3: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
  • 5c7ec0d: 8315862: [11u] Backport 8227337: javax/management/remote/mandatory/connection/ReconnectTest.java NoSuchObjectException no such object in table
  • 269224c: Merge
  • d4254d5: 8315529: [11u] Exclude some failing Z-GC tests
  • d77215a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • 3dd8761: 8306575: Clean up and open source four Dialog related tests
  • 470789a: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 0d9a364: 8306135: Clean up and open source some AWT tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 14, 2023
@openjdk openjdk bot closed this Sep 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@RealCLanger Pushed as commit 94c048f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants