-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8210988: Improved handling of compiler warnings in the build #2606
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @luchenlin, @RealLucy, d:\a\jdk11u-dev\jdk11u-dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): error C2220: the following warning is treated as an error Best regards, Goetz. |
Hi @GoeLin, not sure about this, is this like the related backport? https://bugs.openjdk.org/browse/JDK-8211081 |
…andrewLu_backport_8210988
|
Mailing list message from Lindenmaier, Goetz on jdk-updates-dev: Hi, The problematic coding is It has moved in 17, but is unchanged. Ahh... This is warning C4146, which you remove here: Maybe you need to add it again below. (Instead, you add 4996)? This looks strange, too: make/hotspot/lib/CompileJvm.gmk Doesn't this overwrite the first setting? Should it be Also compare with the original change, or the code in 17. Unfortunately we don't have a build for this platform locally, Best regards, Goetz. |
/integrate |
Going to push as commit 29a08f7.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit 29a08f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.24-oracle.
make/hotspot/lib/CompileGtest.gmk
‘DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft)
4146, \’
make/hotspot/lib/CompileJvm.gmk
DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) 4146, \
The DISABLED_WARNINGS_microsoft change to 4146 as in src\hotspot\cpu\aarch64\register_aarch64.hpp(285)
'uint32_t first = _bitset & -_bitset' remains.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606
$ git checkout pull/2606
Update a local copy of the PR:
$ git checkout pull/2606
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2606/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2606
View PR using the GUI difftool:
$ git pr show -t 2606
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2606.diff
Webrev
Link to Webrev Comment