8078219: Verify lack of @test tag in files in java/net test directory

[jmtd]

Hi,

This pull request contains a backport of commit a9f92be from the openjdk/jdk repository.
The commit being backported was authored by Patrick Concannon on 22 Aug 2019 and was reviewed by Alan Bateman.

This is a clean backport of a test-only patch.
Before the patch: the three tests are not recognised by jtreg as being tests.
After the patch: the three tests are recognised as tests, and pass.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8078219: Verify lack of @test tag in files in java/net test directory

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/406/head:pull/406
$ git checkout pull/406

Update a local copy of the PR:
$ git checkout pull/406
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 406

View PR using the GUI difftool:
$ git pr show -t 406

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/406.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8078219: Verify lack of @test tag in files in java/net test directory

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
• f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
• 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
• 245ccb2: 8269768: JFR Terminology Refresh
• 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
• 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
• b4b50cb: Merge
• c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
• ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
• cb4e287: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
• ... and 22 more: https://git.openjdk.java.net/jdk11u-dev/compare/3d21c7c51b07818077d7a50eb03512e16e69adf4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (9f2d6da3)

[RealCLanger]

@jmtd would you mind integrating this? Thx!

[jmtd]

@RealCLanger I am a mere Author in jdk-updates, not Committer (yet!) so I don't think I can integrate it. I'll issue the command just to be sure...
/integrate

[openjdk]

@jmtd
Your change (at version 9f2d6da) is now ready to be sponsored by a Committer.

[RealCLanger]

@RealCLanger I am a mere Author in jdk-updates, not Committer (yet!) so I don't think I can integrate it. I'll issue the command just to be sure... /integrate

That's fine. You still need to trigger integration via /integrate. Then somebody can sponsor it. I'll do so now.
/sponsor

[openjdk]

Going to push as commit 89d4ef2.
Since your change was applied there have been 32 commits pushed to the master branch:

• e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
• f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
• 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
• 245ccb2: 8269768: JFR Terminology Refresh
• 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
• 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
• b4b50cb: Merge
• c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
• ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
• cb4e287: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
• ... and 22 more: https://git.openjdk.java.net/jdk11u-dev/compare/3d21c7c51b07818077d7a50eb03512e16e69adf4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @jmtd Pushed as commit 89d4ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jmtd]

@RealCLanger

That's fine. You still need to trigger integration via /integrate. Then somebody can sponsor it. I'll do so now.

OK, and thanks for the sponsorship!

Going forward when should I trigger integration? After all the Progress boxes in the PR comment are ticked (including "reviewed" when present/necessary) and/or when the "ready" label is applied?

Thanks

[jmtd]

I wrote:

Going forward when should I trigger integration?

Ah, I remember Severin's comment #356 (comment):

Please only integrate once a 11u maintainer reponded on the jdk11u-fix-request label/comment on the bug.

So once I've got a "-yes" label on the JBS bug and a "ready" label on GH, I shall issue /integrate.

[RealCLanger]

I wrote:

Going forward when should I trigger integration?

Ah, I remember Severin's comment #356 (comment):

Please only integrate once a 11u maintainer reponded on the jdk11u-fix-request label/comment on the bug.

So once I've got a "-yes" label on the JBS bug and a "ready" label on GH, I shall issue /integrate.

Exactly 😄