New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests #639
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
731619b
to
8c12553
Compare
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8226943
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
8c12553
to
aad969d
Compare
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e2b7f1e. |
I backport this for parity with 11.0.14-oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/639/head:pull/639
$ git checkout pull/639
Update a local copy of the PR:
$ git checkout pull/639
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/639/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 639
View PR using the GUI difftool:
$ git pr show -t 639
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/639.diff