Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241598: Upgrade JLine to 3.14.0 #125

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 12, 2021

I'd like to backport JDK-8241598 to 13u for parity with 11u.
The patch applies cleanly.
Follow-up fix JDK-8242030 is planned to be backported as well.
Tested (after applying JDK-8242030) with tier1 and jshell tier2 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/125/head:pull/125
$ git checkout pull/125

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f1ef83b02e40882bad9dc0c0daac071896099529 8241598: Upgrade JLine to 3.14.0 Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241598: Upgrade JLine to 3.14.0

Upgrading to JLine 3.14.0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c229f3c: 8242283: Can't start JVM when java home path includes non-ASCII character

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 12, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Feb 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@kvergizova
Your change (at version 190b404) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 12, 2021

/sponsor

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@yan-too @kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • c229f3c: 8242283: Can't start JVM when java home path includes non-ASCII character

Your commit was automatically rebased without conflicts.

Pushed as commit 7d292c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8241598 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants