Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint #410

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Sep 19, 2022

Hi! Here is backport of JDK-8266082 that fixes javac crash on unallowed annotation usage when running with -Xdoclint option. Original patch applied with the following changes:

  • it patches DocCommentParser.parseParams() method instead of ReferenceParser.parseParams() cuz up to 13u class DocCommentParser relays on own implementation of the method

Verification (amd64/20.04LTS): tools/doclint/CrashInAnnotateTest.java (new test)
Regression (amd64/20.04LTS): test/langtools


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/410/head:pull/410
$ git checkout pull/410

Update a local copy of the PR:
$ git checkout pull/410
$ git pull https://git.openjdk.org/jdk13u-dev pull/410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 410

View PR using the GUI difftool:
$ git pr show -t 410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/410.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0b8a0e2b58dbdd5c9553e502212d32c033a5efb5 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint Sep 19, 2022
@openjdk
Copy link

openjdk bot commented Sep 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 19, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • e024f6d: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
  • 6449dfb: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • 7e5b8d3: 8266172: -Wstringop-overflow happens in vmError.cpp
  • a682e10: 8266170: -Wnonnull happens in classLoaderData.inline.hpp
  • 89bdd28: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 19ce717: 8292579: (tz) Update Timezone Data to 2022c
  • 193032d: 8028265: Add legacy tz tests to OpenJDK
  • 78b30c7: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
  • f9c77a7: 8247818: GCC 10 warning stringop-overflow with symbol code
  • 6ce4b72: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly
  • ... and 26 more: https://git.openjdk.org/jdk13u-dev/compare/91b0a37fe5a01ee084f0d8685391ef6d8fed3539...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2022
@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2022
@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@apavlyutkin
Your change (at version c523009) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 20, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 20, 2022

Going to push as commit a0d9cc2.
Since your change was applied there have been 36 commits pushed to the master branch:

  • e024f6d: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
  • 6449dfb: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • 7e5b8d3: 8266172: -Wstringop-overflow happens in vmError.cpp
  • a682e10: 8266170: -Wnonnull happens in classLoaderData.inline.hpp
  • 89bdd28: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 19ce717: 8292579: (tz) Update Timezone Data to 2022c
  • 193032d: 8028265: Add legacy tz tests to OpenJDK
  • 78b30c7: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
  • f9c77a7: 8247818: GCC 10 warning stringop-overflow with symbol code
  • 6ce4b72: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly
  • ... and 26 more: https://git.openjdk.org/jdk13u-dev/compare/91b0a37fe5a01ee084f0d8685391ef6d8fed3539...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2022
@openjdk openjdk bot closed this Sep 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 20, 2022
@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@yan-too @apavlyutkin Pushed as commit a0d9cc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants