Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9) #30

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link

@kvergizova kvergizova commented Apr 20, 2021

I'd like to backport JDK-8252090 to 15u for parity with 11u.
The patch applies cleanly.
Tested with tier1 and jdk/jfr tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/30.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9924c45faebdba4084c9a5dd5b415dfe6c979024 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9) Apr 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a44e891: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2021

Webrevs

@kvergizova
Copy link
Author

@kvergizova kvergizova commented Apr 21, 2021

/integrate

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@kvergizova Since your change was applied there have been 3 commits pushed to the master branch:

  • 1fc6729: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • dc56503: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • a44e891: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Your commit was automatically rebased without conflicts.

Pushed as commit 6d6a0fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8252090 branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant