Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257633: Missing -mmacosx-version-min=X flag when linking libjvm #37

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 26, 2021

Please review this backport to jdk15u
After the patch applied, minOS version for libjvm.dylib is on par with other libraries
Applies almost clean, only context code difference in patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257633: Missing -mmacosx-version-min=X flag when linking libjvm

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/37.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot changed the title Backport 51d325e613bfcf7f8016ba6d8b146afec6f0f85c 8257633: Missing -mmacosx-version-min=X flag when linking libjvm Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257633: Missing -mmacosx-version-min=X flag when linking libjvm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 26, 2021

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@VladimirKempik Since your change was applied there has been 1 commit pushed to the master branch:

  • a92bbe8: 8257547: Handle multiple prereqs on the same line in deps files

Your commit was automatically rebased without conflicts.

Pushed as commit 981267e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the VladimirKempik:JDK-8257633 branch Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant