Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8267652: c2 loop unrolling by 8 results in reading memory past array #78

Closed
wants to merge 1 commit into from
Closed

8267652: c2 loop unrolling by 8 results in reading memory past array #78

wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jul 16, 2021

Please review this backport to jdk15u-dev
it wasn't applying clean due to the miss of 8223347 in 15u
8223347 is too big to be taken into older JDK, hence I took very small part of 8223347 and included into this backport
This small part moves the location of helper funtions ( like vector_length_in_bytes) in x86.ad
and slighlt changes their signature. it's necessary for predicate(vector_length_in_bytes()) construction to work.
testing - tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267652: c2 loop unrolling by 8 results in reading memory past array

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/78.diff

Please review this backport to jdk15u-dev
it wasn't applying clean due to the miss of 8223347 in 15u
8223347 is too big to be taken into older JDK, hence I took very small part of 8223347 and included into this backport
This small part moves the location of helper funtions ( like vector_length_in_bytes) in x86.ad
and slighlt changes their signature. it's necessary for predicate(vector_length_in_bytes()) construction to work.
testing - hotspot_tier1.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dc12cb78b81f56e9d4b282cf7cad5faa9a9886bf 8267652: c2 loop unrolling by 8 results in reading memory past array Jul 16, 2021
@openjdk
Copy link

openjdk bot commented Jul 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 16, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2021

Webrevs

@VladimirKempik
Copy link
Author

tier1 is fine on fastdebug build as well

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, OK TTBOOK

@openjdk
Copy link

openjdk bot commented Jul 20, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267652: c2 loop unrolling by 8 results in reading memory past array

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2021
@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2021

Going to push as commit ec666c1.

@openjdk openjdk bot closed this Jul 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2021
@openjdk
Copy link

openjdk bot commented Jul 20, 2021

@VladimirKempik Pushed as commit ec666c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8267652 branch July 20, 2021 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants