-
Notifications
You must be signed in to change notification settings - Fork 30
8267652: c2 loop unrolling by 8 results in reading memory past array #78
Conversation
Please review this backport to jdk15u-dev it wasn't applying clean due to the miss of 8223347 in 15u 8223347 is too big to be taken into older JDK, hence I took very small part of 8223347 and included into this backport This small part moves the location of helper funtions ( like vector_length_in_bytes) in x86.ad and slighlt changes their signature. it's necessary for predicate(vector_length_in_bytes()) construction to work. testing - hotspot_tier1.
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
tier1 is fine on fastdebug build as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, OK TTBOOK
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ec666c1. |
@VladimirKempik Pushed as commit ec666c1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport to jdk15u-dev
it wasn't applying clean due to the miss of 8223347 in 15u
8223347 is too big to be taken into older JDK, hence I took very small part of 8223347 and included into this backport
This small part moves the location of helper funtions ( like vector_length_in_bytes) in x86.ad
and slighlt changes their signature. it's necessary for predicate(vector_length_in_bytes()) construction to work.
testing - tier1.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/78/head:pull/78
$ git checkout pull/78
Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/78/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 78
View PR using the GUI difftool:
$ git pr show -t 78
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/78.diff