Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect #12

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 1, 2021

Backport of JDK-8259619. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/12/head:pull/12
$ git checkout pull/12

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce9451208772534efd532a6bc44c226a419f570d 8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect

Reviewed-by: vlivanov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2021

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@TobiHartmann
Copy link
Member Author

Thanks for the reviews, Vladimir and Vladimir!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@TobiHartmann Since your change was applied there have been 4 commits pushed to the master branch:

  • cddbb15: 8259777: Incorrect predication condition generated by ADLC
  • f8af3b5: 8259576: Misplaced curly brace in Matcher::find_shared_post_visit
  • 19b86c4: 8258243: C2: assert failed ("Bad derived pointer") with -XX:+VerifyRegisterAllocator
  • 62e53c8: 8258946: Fix optimization-unstable code involving signed integer overflow

Your commit was automatically rebased without conflicts.

Pushed as commit 58ff0df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
4 participants