Skip to content
This repository has been archived by the owner. It is now read-only.

8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection #32

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Jun 11, 2021

The fix adds check that IOPipe is connected before sending "quit" command


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.java.net/jdk17 pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/32.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 11, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Jun 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 11, 2021

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Alex,
It looks okay in general but I wonder if this is racy.
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Jun 12, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268433: serviceability/dcmd/framework/VMVersionTest.java  fails with Unable to send object throw not established PipeIO Listener  Thread connection

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 12, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Jun 16, 2021

The tests are problem-listed in jdk17 and I have problems with testing windows+zgc builds
Closing this PR and going to continue in jdk18

@alexmenkov alexmenkov closed this Jun 16, 2021
@alexmenkov alexmenkov deleted the ioPipe_quit branch Jun 16, 2021
@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 17, 2021

ProblemListings that are integrated in JDK17 will get sync'ed forward to JDK18.
The thing to do is remove the test from the ProblemList in your PR so that your
test jobs execute your modified test. I don't know whether you think this test
should be fixed in JDK17 or not, but, in any case, you'll (eventually) have to update
the ProblemList in JDK18 also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready rfr serviceability
3 participants