Skip to content

Commit

Permalink
8305236: Some LoadLoad barriers in the interpreter are unnecessary af…
Browse files Browse the repository at this point in the history
…ter JDK-8220051

Reviewed-by: phh
Backport-of: 2c70828e7dc78783c174e3f93c94b6e2439d2dfb
  • Loading branch information
shipilev committed Jun 20, 2023
1 parent bda6723 commit aa3b4e4
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions src/hotspot/cpu/aarch64/templateTable_aarch64.cpp
Expand Up @@ -1748,12 +1748,6 @@ void TemplateTable::float_cmp(bool is_float, int unordered_result)

void TemplateTable::branch(bool is_jsr, bool is_wide)
{
// We might be moving to a safepoint. The thread which calls
// Interpreter::notice_safepoints() will effectively flush its cache
// when it makes a system call, but we need to do something to
// ensure that we see the changed dispatch table.
__ membar(MacroAssembler::LoadLoad);

__ profile_taken_branch(r0, r1);
const ByteSize be_offset = MethodCounters::backedge_counter_offset() +
InvocationCounter::counter_offset();
Expand Down Expand Up @@ -1969,12 +1963,6 @@ void TemplateTable::if_acmp(Condition cc)

void TemplateTable::ret() {
transition(vtos, vtos);
// We might be moving to a safepoint. The thread which calls
// Interpreter::notice_safepoints() will effectively flush its cache
// when it makes a system call, but we need to do something to
// ensure that we see the changed dispatch table.
__ membar(MacroAssembler::LoadLoad);

locals_index(r1);
__ ldr(r1, aaddress(r1)); // get return bci, compute return bcp
__ profile_ret(r1, r2);
Expand Down

1 comment on commit aa3b4e4

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.