8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication

[GoeLin]

…or all If nodes in loop predication

Redo of above change.
The patch of 8308884 applied clean with -R.
Test passes.

I'll backport JDK-8307683, too.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication (Bug - P3)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 2fc0e13e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1497/head:pull/1497
$ git checkout pull/1497

Update a local copy of the PR:
$ git checkout pull/1497
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1497

View PR using the GUI difftool:
$ git pr show -t 1497

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1497.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 03: Full (c04bcd85)
• 02: Full - Incremental (2fc0e13e)
• 01: Full - Incremental (f70ae5f1)
• 00: Full (238f50e3)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[TheRealMDoerr]

Good.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

I will push this only after 8307683.
These two changes have a conflict. When pushing this, I will have
to resolve the renaming of variable proj to if_success_proj in this change.

[GoeLin]

/integrate

[openjdk]

Going to push as commit a6ef655.

[openjdk]

@GoeLin Pushed as commit a6ef655.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.