Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V #1565

Closed

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Jul 11, 2023

I would like to backport JDK-8297476. Patch applies cleanly.
This improves renaissance benchmark performance obviously on linux-riscv64 platform.
And this won't affect other platforms as it doesn't change the default value of the parameter for them.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1565/head:pull/1565
$ git checkout pull/1565

Update a local copy of the PR:
$ git checkout pull/1565
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1565

View PR using the GUI difftool:
$ git pr show -t 1565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1565.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2023

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5e196b4b8e623107424e2fb54672790fd925fe73 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2023

Webrevs

@RealFYang
Copy link
Member Author

Push approval is here. Backport is clean. My local tier1 tier2 tier3 tests on unmatched board are clean.
/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

Going to push as commit a299757.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d5eec58: 8283929: GHA: Add RISC-V build config
  • f956352: 8305421: Work around JDK-8305420 in CDSJDITest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2023
@openjdk openjdk bot closed this Jul 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@RealFYang Pushed as commit a299757.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant