Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V #1567

Closed
wants to merge 3 commits into from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jul 11, 2023

I would like to backport JDK-8309254.
The backport is not clean because 17u has no JDK-8302908, which use v0 as mask register.
The test test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline:

...
240     Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R28, V1-V3
...
0118    Encode ASCII array R12, R11, R13 -> R10 # KILL R12, R11, R13, R25, V1-V3
...

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1567/head:pull/1567
$ git checkout pull/1567

Update a local copy of the PR:
$ git checkout pull/1567
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1567

View PR using the GUI difftool:
$ git pr show -t 1567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1567.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61bb014a8692305c705a4cf0361e319275c35ca3 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Not a JDK Updates Reviewer)
I think this is on par with https://bugs.openjdk.org/browse/JDK-8274243 which has been backported to jdk17u.

@DingliZhang
Copy link
Member Author

DingliZhang commented Jul 12, 2023

Tier1-3 with UseRVV looks good.
Could we have a Reviewer?

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2023

@DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4dca60e: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 41cadb7: 8313765: Invalid CEN header (invalid zip64 extra data field size)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2023
@DingliZhang
Copy link
Member Author

@RealFYang Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2023
@openjdk
Copy link

openjdk bot commented Aug 20, 2023

@DingliZhang
Your change (at version 539e39f) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 20, 2023

Going to push as commit 0fa04fe.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4dca60e: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 41cadb7: 8313765: Invalid CEN header (invalid zip64 extra data field size)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 20, 2023
@openjdk openjdk bot closed this Aug 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 20, 2023
@openjdk
Copy link

openjdk bot commented Aug 20, 2023

@RealFYang @DingliZhang Pushed as commit 0fa04fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants