-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V #1567
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. (Not a JDK Updates Reviewer)
I think this is on par with https://bugs.openjdk.org/browse/JDK-8274243 which has been backported to jdk17u.
Tier1-3 with UseRVV looks good. |
@DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@RealFYang Thanks for the review! |
@DingliZhang |
/sponsor |
Going to push as commit 0fa04fe.
Your commit was automatically rebased without conflicts. |
@RealFYang @DingliZhang Pushed as commit 0fa04fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport JDK-8309254.
The backport is not clean because 17u has no JDK-8302908, which use v0 as mask register.
The test
test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java
passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline:Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1567/head:pull/1567
$ git checkout pull/1567
Update a local copy of the PR:
$ git checkout pull/1567
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1567/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1567
View PR using the GUI difftool:
$ git pr show -t 1567
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1567.diff
Webrev
Link to Webrev Comment