8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

[gnu-andrew]

The security fix, JDK-8300596, introduced a maximum size for signature-related files in JAR files, via the jdk.jar.maxSignatureFileSize property. The default value of 8MB has since proven to be too low for some JARs in general use. This change doubles it to 16MB, while still being much lower than the previous MAX_ARRAY_SIZE value of Integer.MAX_VALUE - 8

This pull request contains a clean backport of commit e47a84f2 from the openjdk/jdk repository.

The commit being backported was authored by Hai-May Chao on 31 Jul 2023 and was reviewed by Sean Mullan and Matthias Baesken.

---

Progress

• Change requires CSR request JDK-8313216 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (Enhancement - P3)
• JDK-8313216: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1703/head:pull/1703
$ git checkout pull/1703

Update a local copy of the PR:
$ git checkout pull/1703
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1703/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1703

View PR using the GUI difftool:
$ git pr show -t 1703

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1703.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• a64639f: 8312974: Bump update version for OpenJDK: jdk-17.0.10
• 25efecc: 8313262: C2: Sinking node may cause required cast to be dropped
• f09ba79: 8314020: Print instruction blocks in byte units
• a75e5de: 8313678: SymbolTable can leak Symbols during cleanup
• c91fb3f: 8313874: JNI NewWeakGlobalRef throws exception for null arg
• 7ea65a0: Merge
• 0f29caa: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• b31f232: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1
• d82de1c: 8314517: some tests fail in case ipv6 is disabled on the machine
• 1d65a31: 8284772: GHA: Use GCC Major Version Dependencies Only
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/4c123ac3146ccec1bb168751fc38d3fcdd973190...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (be52d5c4)

[gnu-andrew]

I see jdk17u-fix-yes.
/integrate

[openjdk]

Going to push as commit 5b613e3.
Since your change was applied there have been 22 commits pushed to the master branch:

• f85df30: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores
• 8d70429: 8313626: C2 crash due to unexpected exception control flow
• 7f3f76f: 8286430: make test TEST="gtest:" exits with error when it shouldn't
• eb639a2: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
• 804ce09: 8312620: WSL Linux build crashes after JDK-8310233
• e0b39c7: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
• e6b87a7: 8312182: THPs cause huge RSS due to thread start timing issue
• fbe3773: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
• 0d4fbb4: 8295229: Try to verify gtest version
• 3681719: 8310233: Fix THP detection on Linux
• ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/4c123ac3146ccec1bb168751fc38d3fcdd973190...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 5b613e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.