8301489: C1: ShortLoopOptimizer might lift instructions before their inputs

[GoeLin]

I backport this for parity with 17.0.10-oracle.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8301489 needs maintainer approval

Issue

• JDK-8301489: C1: ShortLoopOptimizer might lift instructions before their inputs (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1826/head:pull/1826
$ git checkout pull/1826

Update a local copy of the PR:
$ git checkout pull/1826
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1826

View PR using the GUI difftool:
$ git pr show -t 1826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1826.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (96923e9c)

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301489: C1: ShortLoopOptimizer might lift instructions before their inputs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• bf2d133: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
• 60ae78a: 8298872: Update CheckStatus.java for changes to TLS implementation
• 8ef142e: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3
• 31422d7: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
• f1c55d2: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
• 20d41b9: 8297958: NMT: Display peak values
• 76fd18e: 8292072: NMT: repurpose Tracking overhead counter as global malloc counter
• aa54750: 8281015: Further simplify NMT backend
• fa40b5f: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
• 2589bf3: 8316514: Better diagnostic header for VtableStub
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/ceafbb759e515e4ca42de18a0d6423e35d176059...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 273872c.
Since your change was applied there have been 16 commits pushed to the master branch:

• 9dc5ff0: 8299075: TestStringDeduplicationInterned.java fails because extra deduplication
• c8bc1c2: 8307403: java/util/zip/DeInflate.java timed out
• 76a402d: 8301455: comments in TestTypeAnnotations still refer to resolved JDK-8068737
• 4c0171a: 8305505: NPE in javazic compiler
• 1cbcea2: 8298298: NMT: count deltas are printed with 32-bit signed size
• bf2d133: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
• 60ae78a: 8298872: Update CheckStatus.java for changes to TLS implementation
• 8ef142e: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3
• 31422d7: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
• f1c55d2: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/ceafbb759e515e4ca42de18a0d6423e35d176059...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 273872c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.