Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp #1926

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 26, 2023

I backport this for parity with 17.0.11-oracle.


Progress

  • JDK-8314144 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1926/head:pull/1926
$ git checkout pull/1926

Update a local copy of the PR:
$ git checkout pull/1926
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1926

View PR using the GUI difftool:
$ git pr show -t 1926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1926.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1925508425cf1b2d46173754077a588290253430 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • d7dd1f0: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • 28e9fd3: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 03552ee: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 3af0c4f: 8317373: Add Telia Root CA v2
  • fc28856: 8308910: Allow executeAndLog to accept running process
  • f85053f: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 5a9ceba: 8228990: JFR: TestNetworkUtilizationEvent.java expects 2+ Network interfaces on Linux but finding 1
  • 93127b4: 8273456: Do not hold ttyLock around stack walking
  • 2c75188: 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 29, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

Going to push as commit d61229d.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 03e3232: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • d7dd1f0: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • 28e9fd3: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 03552ee: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 3af0c4f: 8317373: Add Telia Root CA v2
  • fc28856: 8308910: Allow executeAndLog to accept running process
  • f85053f: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 5a9ceba: 8228990: JFR: TestNetworkUtilizationEvent.java expects 2+ Network interfaces on Linux but finding 1
  • 93127b4: 8273456: Do not hold ttyLock around stack walking
  • 2c75188: 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2023
@openjdk openjdk bot closed this Oct 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@GoeLin Pushed as commit d61229d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant