8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

[zifeihan]

Hi, this backport to make the test_bit assember function more simpler and to improve performance when the parameter (1UL << bit_pos) exceeds 32-bit range. This is a risc-v specific change.
Backport is not clean. because the fastlock needs to call test_bit, in the mainline version, the fastlock function is renamed and moved to c2_MacroAssembler_riscv.cpp, but in jdk17u-dev, fastlock is still in riscv.ad.

Testing:

qemu 8.1.50:

• Tier1 tests (release)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318953 needs maintainer approval

Issue

• JDK-8318953: RISC-V: Small refactoring for MacroAssembler::test_bit (Enhancement - P4 - Approved)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1941/head:pull/1941
$ git checkout pull/1941

Update a local copy of the PR:
$ git checkout pull/1941
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1941

View PR using the GUI difftool:
$ git pr show -t 1941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1941.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (39e0a150)

[RealFYang]

Looks good.

[openjdk]

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 594e5d7: 8312467: relax the builddir check in make/autoconf/basic.m4
• 8922e52: 8312612: handle WideCharToMultiByte return values

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zifeihan]

@RealFYang Thanks for your review.
/integrate

[RealFYang]

/sponsor

[openjdk]

@zifeihan
Your change (at version 39e0a15) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 348a703.
Since your change was applied there have been 2 commits pushed to the master branch:

• 594e5d7: 8312467: relax the builddir check in make/autoconf/basic.m4
• 8922e52: 8312612: handle WideCharToMultiByte return values

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit 348a703.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.